From how I understand the wiki it should be either highway=crossing crossing=traffic_signals with the crossing tags (kerb etc.) and then highway=traffic_signals on a separate node; or if we want to map both in one node then highway=traffic_signals crossing=traffic_signals. Like here: https://www.openstreetmap.org/node/2916183481