Prioritize explicit player payment service routing

apps/chat/services/backend_orchestration.py

@@ -31,6 +31,17 @@ REQUIRED_FIELDS = {
 }
 
 
+def _public_confidence(value: Any, default: float = 0.0) -> float:
+    """Normalize internal percentage/ranking scores to the public 0..1 contract."""
+    try:
+        score = float(value)
+    except (TypeError, ValueError):
+        score = default
+    if score > 1.0:
+        score /= 100.0
+    return round(max(0.0, min(score, 1.0)), 4)
+
+
 def decide_chatbot_response(message: str, context: Dict[str, Any], bot_payload: Dict[str, Any]) -> Dict[str, Any]:
     msg = (message or "").strip()
     allowed = set(context.get("allowed_service_ids") or [])
@@ -50,7 +61,7 @@ def decide_chatbot_response(message: str, context: Dict[str, Any], bot_payload:
                 return {
                     "type": "CLARIFICATION_REQUIRED",
                     "service_id": service_id,
-                    "confidence": float(request.get("confidence") or bot_payload.get("score") or 0.8),
+                    "confidence": _public_confidence(request.get("confidence") or bot_payload.get("score"), 0.8),
                     "missing_fields": missing,
                     "question": "Please provide " + ", ".join(missing) + " so I can understand the request.",
                     "safety": {"safe": True, "risk_level": "LOW"},
@@ -58,7 +69,7 @@ def decide_chatbot_response(message: str, context: Dict[str, Any], bot_payload:
             return {
                 "type": "SERVICE_REQUEST",
                 "service_id": service_id,
-                "confidence": float(request.get("confidence") or bot_payload.get("score") or 0.8),
+                "confidence": _public_confidence(request.get("confidence") or bot_payload.get("score"), 0.8),
                 "missing_fields": [],
                 "extracted_data": extracted,
                 "user_message": "The service intent and parameters were detected. The backend must authorize and execute it.",
@@ -91,7 +102,7 @@ def decide_chatbot_response(message: str, context: Dict[str, Any], bot_payload:
         "type": "KNOWLEDGE_QA",
         "answer": bot_payload.get("response") or bot_payload.get("answer") or "I could not find a confident answer.",
         "response": bot_payload.get("response") or bot_payload.get("answer") or "I could not find a confident answer.",
-        "confidence": float(bot_payload.get("score") or bot_payload.get("confidence") or 0.0),
+        "confidence": _public_confidence(bot_payload.get("score") or bot_payload.get("confidence"), 0.0),
         "source": bot_payload.get("source") or "data.csv",
         "matched_question": bot_payload.get("matched_question"),
         "tenant_scope": context.get("tenant_scope") or "GLOBAL",
@@ -139,4 +150,4 @@ def finalize_service_response(payload: Dict[str, Any]) -> Dict[str, Any]:
         message = result.get("safe_summary") or "I need your confirmation before completing this action."
     else:
         message = result.get("safe_summary") or result.get("error") or f"I could not complete the {service_id.replace('_', ' ')} service."
-    return {"type": "SERVICE_FINAL_RESPONSE", "message": str(message), "response": str(message), "service_id": service_id, "status": status}
+    return {"type": "SERVICE_FINAL_RESPONSE", "message": str(message), "response": str(message), "service_id": service_id, "status": status}

apps/chat/services/service_detection.py

@@ -618,6 +618,27 @@ class ServiceDetector:
             ' pending ',
             ' overdue ',
         ))
+        wants_player_payment_data = (
+            any(term in padded for term in (' player ', ' footballer ', ' athlete '))
+            and any(term in padded for term in (
+                ' payment ',
+                ' payments ',
+                ' invoice ',
+                ' invoices ',
+                ' bill ',
+                ' bills ',
+                ' fee ',
+                ' fees ',
+            ))
+        )
+        if wants_player_payment_data:
+            matches.append({
+                'service_id': 'get-player-payments',
+                'confidence': 133.0,
+                'source': 'rule_based_operation',
+                'matched_example': 'payments for a player',
+            })
+
         if wants_personal_payments:
             matches.append({
                 'service_id': 'get-pending-payments' if wants_pending_payment_list else 'get-payment-status',

apps/chat/tests/test_service_integration.py

@@ -504,6 +504,43 @@ def test_mobile_service_prompts_route_before_kb():
         assert detected[0]["service_id"] == service_id
 
 
+def test_explicit_player_payment_terms_beat_player_profile_match():
+    """Payment nouns must select payment routing even when a player name is present."""
+    from apps.chat.services.service_detection import get_service_detector
+
+    detector = get_service_detector()
+    detected = detector.detect_service_requests(
+        "show invoices for player John Smith from 2026-06-01 to 2026-06-30",
+        context={"user_id": 1, "role": "ADMIN", "academy_id": 32},
+        threshold=70.0,
+    )
+
+    assert detected
+    assert detected[0]["service_id"] == "get-player-payments"
+
+
+def test_public_service_confidence_is_normalized():
+    """Internal router ranking scores must not leak outside the 0..1 API contract."""
+    from apps.chat.services.backend_orchestration import decide_chatbot_response
+
+    response = decide_chatbot_response(
+        "show player payments",
+        {},
+        {
+            "service_requests": [
+                {
+                    "service_id": "get-player-payments",
+                    "confidence": 133.0,
+                    "parameters": {"player": "John Smith"},
+                }
+            ]
+        },
+    )
+
+    assert response["type"] == "SERVICE_REQUEST"
+    assert response["confidence"] == 1.0
+
+
 def test_model_extraction_enriches_detected_service_parameters():
     """Detected services should be enriched by the trained model without replacing context IDs."""
     from apps.chat.services.service_detection import get_service_detector